[PATCH] D150855: MachineCombiner: consider all uses in getLatency()

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 03:48:59 PDT 2023


barannikov88 added a comment.

This will still work because virtual registers cannot be implicit operands, and there is a check for virtualness above.
Still, using `defs` and `uses` should be avoided because they have unexpected behavior.
I hope they can be removed someday and then reimplemented correctly w.r.t. implicit operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150855/new/

https://reviews.llvm.org/D150855



More information about the llvm-commits mailing list