[PATCH] D143320: [bazel] Rework zlib dependency

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal planned changes to this revision.
aaronmondal added a comment.

The "migration" necessitated by this patch is pretty much the exact same as for the zstd commit https://reviews.llvm.org/D143344. The "system" behavior is still possible, but requires the workaround you proposed in https://reviews.llvm.org/D143344. Is that workaround good enough for your needs?

The current bzlmod patches don't allow customization of external dependencies and we need changes like this one to remove dependencies on `maybe` (which is incompatible with bzlmod by design). It's not exactly "blocking" the patches per se, but it blocks them from being customizable.

I'd also like to move this forward since it would finally get rid of all the zlib deprecation warnings when building with a recent clang and it fixes layering-check issues.



================
Comment at: utils/bazel/third_party_build/zlib-ng.BUILD:94-96
+        # For local builds you might want to enable this to improve performance.
+        # It's disabled in the default config for reproducibility.
+        # "-DWITH_NATIVE_INSTRUCTIONS",
----------------
GMNGeoffrey wrote:
> I don't understand the comment. It looks like it's enabled by default here?
Oh yes this is definitely wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143320/new/

https://reviews.llvm.org/D143320