[PATCH] D143320: [bazel] Rework zlib dependency

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

This shows up in "must review" for me, but I think the ball's in your court for preserving the ability to easily set up a dependent project. Please LMK if this (or any of your related patches) are blocked on my review.



================
Comment at: utils/bazel/third_party_build/zlib-ng.BUILD:94-96
+        # For local builds you might want to enable this to improve performance.
+        # It's disabled in the default config for reproducibility.
+        # "-DWITH_NATIVE_INSTRUCTIONS",
----------------
I don't understand the comment. It looks like it's enabled by default here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143320/new/

https://reviews.llvm.org/D143320