[PATCH] D143320: [bazel] Rework zlib dependency
Geoffrey Martin-Noble via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 16 18:00:04 PDT 2023
GMNGeoffrey added a comment.
In D143320#4348332 <https://reviews.llvm.org/D143320#4348332>, @aaronmondal wrote:
> Is that workaround good enough for your needs?
It's not ideal from a user perspective that I have to copy-paste code from the workspace. We migrated with the change to zstd though 🤷 The usage of system zlib is something I'm advocating making possible based on recollections of past conversations with Chandler. This doesn't make people accidentally depend on an external version though, so I think it's not terrible from that perspective. I wish the ergonomics were a bit better, but I'm fine with this going in
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143320/new/
https://reviews.llvm.org/D143320
More information about the llvm-commits
mailing list