[PATCH] D143285: X86: completely refactor `X86FrameLowering::emitPrologue`

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added a comment.

I'm not sure whether I should proceed with further comments. Once all of the
already expressed concerns are addressed, the result will resemble the original
code before refactoring, with the exception that some code was extracted into
small functions. I'll let X86 maintainers to take a look first.

---

I'm not an X86 guy, but I studied this code because X86 and my target share
a few concepts. Even though the function is large, I personally found it easy
to follow. It can still benefit from factoring out pieces of code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143285/new/

https://reviews.llvm.org/D143285