[PATCH] D143285: X86: completely refactor `X86FrameLowering::emitPrologue`

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 05:18:19 PDT 2023


barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:1429
+  // Indicates if the frame needs stack probes to be emitted.
+  bool ShouldEmitStackProbe;
+  unsigned StackProbeSize;
----------------
barannikov88 wrote:
> This variable is used only in one place. Just call `TLI->hasStackProbeSymbol(MF)` directly.
> The same is true for most of the other variables.
> 
> This variable is used only in one place.
I was wrong, it is used in several places.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143285/new/

https://reviews.llvm.org/D143285



More information about the llvm-commits mailing list