[PATCH] D143285: X86: completely refactor `X86FrameLowering::emitPrologue`

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:1429
+  // Indicates if the frame needs stack probes to be emitted.
+  bool ShouldEmitStackProbe;
+  unsigned StackProbeSize;
----------------
This variable is used only in one place. Just call `TLI->hasStackProbeSymbol(MF)` directly.
The same is true for most of the other variables.



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:1688
+  void EmitWinCFI(unsigned CFI, std::initializer_list<int64_t> Args = {}) {
+    if (!ShouldEmitWinCFI)
+      return;
----------------
Such kind of checks should be done at the call site.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143285/new/

https://reviews.llvm.org/D143285