[PATCH] D150144: cmake: add missing dependency on Attributes.inc

[Alex Langford via Phabricator via llvm-commits]

bulbazord requested changes to this revision.
bulbazord added a comment.
This revision now requires changes to proceed.

Yeah, it sure looks like we're tablegen-ing something and not attaching it to a CMake target... The idea of this seems correct.

You're making LLVMAsmParser depend on this which looks correct, but a quick `grep` through the LLVM code base shows that some files in `lib/IR` use it as well, so `LLVMCore` probably needs this dependency too.



================
Comment at: llvm/utils/TableGen/CMakeLists.txt:90-91
+
+  DEPENDS
+  attributes_gen
   )
----------------
Is this right? llvm-tblgen depends on a file generated by llvm-tblgen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144