[PATCH] D150144: cmake: add missing dependency on Attributes.inc

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 14:29:43 PDT 2023


jroelofs updated this revision to Diff 520483.
jroelofs added reviewers: mehdi_amini, jrtc27.
Herald added a subscriber: hiraditya.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144

Files:
  llvm/include/llvm/IR/CMakeLists.txt
  llvm/lib/AsmParser/CMakeLists.txt
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/utils/TableGen/CMakeLists.txt


Index: llvm/utils/TableGen/CMakeLists.txt
===================================================================
--- llvm/utils/TableGen/CMakeLists.txt
+++ llvm/utils/TableGen/CMakeLists.txt
@@ -86,6 +86,9 @@
   X86RecognizableInstr.cpp
   WebAssemblyDisassemblerEmitter.cpp
   $<TARGET_OBJECTS:obj.LLVMTableGenCommon>
+
+  DEPENDS
+  attributes_gen
   )
 target_link_libraries(llvm-tblgen PRIVATE LLVMTableGenGlobalISel)
 set_target_properties(llvm-tblgen PROPERTIES FOLDER "Tablegenning")
Index: llvm/unittests/Analysis/CMakeLists.txt
===================================================================
--- llvm/unittests/Analysis/CMakeLists.txt
+++ llvm/unittests/Analysis/CMakeLists.txt
@@ -64,6 +64,8 @@
   ${ANALYSIS_TEST_SOURCES}
   )
 
+add_dependencies(AnalysisTests attributes_gen)
+
 target_link_libraries(AnalysisTests PRIVATE LLVMTestingSupport)
 
 # On AIX, enable run-time linking to allow symbols from the plugins shared
Index: llvm/lib/AsmParser/CMakeLists.txt
===================================================================
--- llvm/lib/AsmParser/CMakeLists.txt
+++ llvm/lib/AsmParser/CMakeLists.txt
@@ -8,6 +8,7 @@
   ${LLVM_MAIN_INCLUDE_DIR}/llvm/ASMParser
 
   DEPENDS
+  attributes_gen
   intrinsics_gen
 
   LINK_COMPONENTS
Index: llvm/include/llvm/IR/CMakeLists.txt
===================================================================
--- llvm/include/llvm/IR/CMakeLists.txt
+++ llvm/include/llvm/IR/CMakeLists.txt
@@ -1,5 +1,6 @@
 set(LLVM_TARGET_DEFINITIONS Attributes.td)
 tablegen(LLVM Attributes.inc -gen-attrs)
+add_public_tablegen_target(attributes_gen)
 
 set(LLVM_TARGET_DEFINITIONS Intrinsics.td)
 tablegen(LLVM IntrinsicImpl.inc -gen-intrinsic-impl)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150144.520483.patch
Type: text/x-patch
Size: 1685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230508/eba4a7e2/attachment.bin>


More information about the llvm-commits mailing list