[PATCH] D150144: cmake: add missing dependency on Attributes.inc

Alex Langford via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 15:12:24 PDT 2023


bulbazord added inline comments.


================
Comment at: llvm/utils/TableGen/CMakeLists.txt:90-91
+
+  DEPENDS
+  attributes_gen
   )
----------------
bulbazord wrote:
> Is this right? llvm-tblgen depends on a file generated by llvm-tblgen?
Ok, I looked into this further. All the headers that get generated (everything in `llvm/include/llvm/`) are generated by `llvm-min-tblgen`, which is defined above. It **does** make sense for `llvm-tblgen` to depend on `attributes_gen`. This is not a concern anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144



More information about the llvm-commits mailing list