[PATCH] D150142: [InstCombine] Add simplifications for div/rem with `i1` operands; PR62607

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 13:36:57 PDT 2023


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

Missing InstSimplify tests. The check for this was dropped as part of https://github.com/llvm/llvm-project/commit/946b32680311f43a349d0199f9e286f385cd9847, and apparently had no test coverage? Though I don't really get why the new KnownBits based code doesn't cover this: For i1 type I'd expect `Known.countMinLeadingZeros() == Known.getBitWidth() - 1` to evaluate to true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150142/new/

https://reviews.llvm.org/D150142



More information about the llvm-commits mailing list