[PATCH] D148109: [mlir] Add a generic mem2reg implementation.

[Théo Degioanni via Phabricator via llvm-commits]

Moxinilian added a comment.

Hopefully this clarifies!



================
Comment at: mlir/include/mlir/Transforms/Passes.td:191
+    within subregions will not happen.
+  }];
+}
----------------
mehdi_amini wrote:
> Is it conservative with respect to aliasing? How is this handled?
Aliasing is structurally not allowed: for promotion to happen, all users of the alloca must implement one of the mem2reg interfaces, and those do not allow aliasing. I agree that this is not very clear here and in the documentation of the interfaces. I will open a subsequent revision to make this obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148109/new/

https://reviews.llvm.org/D148109