[PATCH] D149798: [BOLT][DWARF] Fix handling of loclists_base without location accesses

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 16:36:51 PDT 2023


ayermolo created this revision.
Herald added subscribers: treapster, hoy, modimo, wenlei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
ayermolo requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, jplehr, yota9, sstefan1.
Herald added a project: LLVM.

There are CUs that have DW_AT_loclists_base, but no DW_AT_location in children
DIEs. Pre-bolt it points to a valid offset. We were not updating it, so it ended
up pointing in the middle of a list and caused LLDB to print out errors. Changed
it to point to first location list. I don't think it should matter since there
are no accesses to it anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149798

Files:
  bolt/lib/Core/DebugData.cpp
  bolt/test/X86/Inputs/dwarf5-loc-base-no-loc-accesshelper.s
  bolt/test/X86/dwarf5-one-loclists-two-bases.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149798.519300.patch
Type: text/x-patch
Size: 23960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230503/7fc5784c/attachment.bin>


More information about the llvm-commits mailing list