[PATCH] D149486: [RISCV] Strengthen atomic ordering for sequentially consistent stores

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 08:56:05 PDT 2023


paulkirth added a comment.

In D149486#4315071 <https://reviews.llvm.org/D149486#4315071>, @asb wrote:

> The change looks good to me from a strictly code review perspective. I agree it would be good to see the concerns about a future ABI break fleshed out in the psABI issue tracker or mailing list.
>
> As people might want to find the first version of LLVM that changed to this lowering that's more compatible with A.7, perhaps you could compose an appropriate release note? I'll admit it's a bit subtle to explain briefly.

Thanks for raising that issue.  This will definitely need a release note. I'll try to keep it brief but it may take a few iterations to get something that explains the issue succinctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149486/new/

https://reviews.llvm.org/D149486



More information about the llvm-commits mailing list