[PATCH] D149486: [RISCV] Strengthen atomic ordering for sequentially consistent stores

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 04:03:41 PDT 2023


asb added a comment.

The change looks good to me from a strictly code review perspective. I agree it would be good to see the concerns about a future ABI break fleshed out in the psABI issue tracker or mailing list.

As people might want to find the first version of LLVM that changed to this lowering that's more compatible with A.7, perhaps you could compose an appropriate release note? I'll admit it's a bit subtle to explain briefly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149486/new/

https://reviews.llvm.org/D149486



More information about the llvm-commits mailing list