[PATCH] D148483: RISC-V Zvk (vector crypto) specification update to 0.4 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

I started to review this - one thing I wanted to note quickly as it may impact other reviewers is that this update is written against something newer than the linked 0.4.6 release. I was confused about not being able to find zvksg and zvkng in the linked PDF, but see they were added a couple of weeks ago to the spec (i.e. after the 0.4.6 pdf) https://github.com/riscv/riscv-crypto/commit/6acf08361ed48eb85c5a562b54b99698d466f5f3

Looking at the commits since 0.4.6 https://github.com/riscv/riscv-crypto/compare/v20230322...master it seems zvksg/zvkng is the only change that's going to impact MC layer support and the version was bumped to 0.5.2, so perhaps 0.5 is a more accurate version number?



================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:151
+    {"zvkg", RISCVExtensionVersion{0, 4}},
+    {"zvkg", RISCVExtensionVersion{0, 4}},
+    {"zvkn", RISCVExtensionVersion{0, 4}},
----------------
"zvkg" is duplicated


================
Comment at: llvm/test/MC/RISCV/rvv/zvbb.s:106
+# CHECK-UNKNOWN: 57 b5 9e d4   <unknown>
+
----------------
Nit: I don't think you want a blank line here (only spotted as `git apply` complains).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148483/new/

https://reviews.llvm.org/D148483