[PATCH] D148483: RISC-V Zvk (vector crypto) specification update to 0.4 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:901
+
+  if ((Exts.count("zvkg") || Exts.count("zvkn") || Exts.count("zvkned") ||
+       Exts.count("zvkng") || Exts.count("zvknha") || Exts.count("zvks") ||
----------------
I'm not sure it makes sense to list composite extensions like zvkn and zvks and zvksg here, as the dependencies are going to be checked on the sub-extensions they imply anyway.


================
Comment at: llvm/lib/Target/RISCV/RISCVFeatures.td:520
+                       "This extension is shorthand for the following set of "
+                       "other extensions: Zvkn and Zvkt.">;
 
----------------
Zvkt => Zvkg


================
Comment at: llvm/lib/Target/RISCV/RISCVFeatures.td:549
+                       "This extension is shorthand for the following set of "
+                       "other extensions: Zvks and Zvkt.">;
+
----------------
Zvkt => Zvkg


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148483/new/

https://reviews.llvm.org/D148483