[PATCH] D148198: [ReachingDefs] make ReachingDefDefaultVal smaller
Jon Roelofs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 18 08:33:19 PDT 2023
jroelofs added a comment.
In D148198#4264234 <https://reviews.llvm.org/D148198#4264234>, @yubing wrote:
> @craig.topper hi, Craig. why we don't set it as std::numeric_limits<int>::min() previously?
I think it can only go as small as `-(1 << 30)`, since the pointer traits in `ReachingDef` takes the last two bits.
We have seen values between `-(1<<21)` and `-(1<<20)` in some workloads tripping the `Defs must be sorted and unique` assertion, so it may be prudent to set it to at least `-(1<<22)`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148198/new/
https://reviews.llvm.org/D148198
More information about the llvm-commits
mailing list