[PATCH] D148608: [X86] Create all-one vector(v8i32) for TESTC(X,~X) == TESTC(X,-1) if X is v8f32

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 00:46:13 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/CodeGen/X86/combine-testp-v8f32.ll:9
+; AVX-NEXT:    vcmptrueps %ymm1, %ymm1, %ymm1
+; AVX-NEXT:    vxorps %ymm1, %ymm0, %ymm1
+; AVX-NEXT:    vtestps %ymm1, %ymm0
----------------
I think you need to regenerate this. It failed when I just tested locally.

```
modified   llvm/test/CodeGen/X86/combine-testp-v8f32.ll
@@ -6,7 +6,6 @@ define void @test(<8 x i32> %ref.tmp.sroa.0.16.vec.expand.i.i.i.i.i.i.i) #0 pers
 ; AVX:       # %bb.0: # %entry
 ; AVX-NEXT:    vxorps %xmm1, %xmm1, %xmm1
 ; AVX-NEXT:    vcmptrueps %ymm1, %ymm1, %ymm1
-; AVX-NEXT:    vxorps %ymm1, %ymm0, %ymm1
 ; AVX-NEXT:    vtestps %ymm1, %ymm0
 ; AVX-NEXT:    vzeroupper
 ; AVX-NEXT:    retq


```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148608/new/

https://reviews.llvm.org/D148608



More information about the llvm-commits mailing list