[PATCH] D148608: [X86] Create all-one vector(v8i32) for TESTC(X,~X) == TESTC(X,-1) if X is v8f32

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 00:47:34 PDT 2023


goldstein.w.n added a comment.

In D148608#4276765 <https://reviews.llvm.org/D148608#4276765>, @yubing wrote:

> In D148608#4276752 <https://reviews.llvm.org/D148608#4276752>, @goldstein.w.n wrote:
>
>> Why is this important?
>
> since getAllOnesConstant can only take v8i32 instead of v8f32

Oh I see. Makes sense. Can you mention that in the summary/commit message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148608/new/

https://reviews.llvm.org/D148608



More information about the llvm-commits mailing list