[PATCH] D148608: [X86] Create all-one vector(v8i32) for TESTC(X,~X) == TESTC(X,-1) if X is v8f32

Tue Apr 18 00:45:03 PDT 2023

yubing added a comment.

In D148608#4276752 <https://reviews.llvm.org/D148608#4276752>, @goldstein.w.n wrote:

> Why is this important?

since getAllOnesConstant can only take v8i32 instead of v8f32

================
Comment at: llvm/test/CodeGen/X86/combine-testp-v8f32.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=avx | FileCheck %s --check-prefix=AVX
----------------
goldstein.w.n wrote:
> Can you split the test into a seperate patch  (i.e test file compiled with llc before this change) so we can see the diff this patch generates?
sorry i can't. it is compfail without this diff.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148608/new/

https://reviews.llvm.org/D148608