[PATCH] D148116: [Analysis] Remove DA & LegacyDA

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a reviewer: simoll.
foad added a comment.
This revision is now accepted and ready to land.

LGTM with nits.



================
Comment at: llvm/docs/ConvergenceAndUniformity.rst:54
 semantics of convergent operations in LLVM IR. This is accompanied by
-a *uniformity analysis* that extends the existing divergence analysis
+a *uniformity analysis* that extends the (now removed) divergence analysis
 [DivergenceSPMD]_ to cover irreducible control-flow.
----------------
Maybe remove the whole sentence?


================
Comment at: llvm/include/llvm/ADT/GenericUniformityInfo.h:16
 // #include "llvm/ADT/Uniformity.h"
-// #include "llvm/Analysis/LegacyDivergenceAnalysis.h"
 #include "llvm/Support/raw_ostream.h"
----------------
Might as well remove all the commented-out `#include`s.


================
Comment at: llvm/test/CodeGen/AMDGPU/always-uniform.ll:7
 
-; OPT-LABEL: define amdgpu_kernel void @readfirstlane_uniform(
-; OPT-NEXT:    %tid = tail call i32 @llvm.amdgcn.workitem.id.x()
----------------
What was the point of this part of the test? Should it be updated to test UA instead of LDA?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148116/new/

https://reviews.llvm.org/D148116