[PATCH] D148116: [Analysis] Remove DA & LegacyDA

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh marked an inline comment as done.
Pierre-vh added inline comments.


================
Comment at: llvm/docs/ConvergenceAndUniformity.rst:54
 semantics of convergent operations in LLVM IR. This is accompanied by
-a *uniformity analysis* that extends the existing divergence analysis
+a *uniformity analysis* that extends the (now removed) divergence analysis
 [DivergenceSPMD]_ to cover irreducible control-flow.
----------------
foad wrote:
> Maybe remove the whole sentence?
There is a citation in there so I would like to find a way to keep it in or rephrase it
@sameerds you wrote this document, how would you like me to update it?


================
Comment at: llvm/test/CodeGen/AMDGPU/always-uniform.ll:7
 
-; OPT-LABEL: define amdgpu_kernel void @readfirstlane_uniform(
-; OPT-NEXT:    %tid = tail call i32 @llvm.amdgcn.workitem.id.x()
----------------
foad wrote:
> What was the point of this part of the test? Should it be updated to test UA instead of LDA?
I'm really not sure what was the point, UA doesn't print anything. Maybe it was just checking DA could run fine on the test without crashing? (though that's already verified by running llc)
Note that I tried using `-passes=uniform` and it doesn't recognize it, I'm not sure how to run uniformity analysis alone using opt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148116/new/

https://reviews.llvm.org/D148116