[PATCH] D148116: [Analysis] Remove DA & LegacyDA

Wed Apr 12 04:45:08 PDT 2023

Pierre-vh created this revision.
Pierre-vh added reviewers: arsenm, foad, nhaehnle, sameerds, jholewinski, jdoerfert.
Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, StephenFan, kerbowa, hiraditya, jvesely.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, wdng.
Herald added a project: LLVM.

UniformityAnalysis offers all of the same features and much more, there is no reason left to use the legacy DAs.
See RFC: https://discourse.llvm.org/t/rfc-deprecate-divergenceanalysis-legacydivergenceanalysis/69538

- Remove LegacyDivergenceAnalysis.h/.cpp
- Remove DivergenceAnalysis.h/.cpp + Unit tests
- Remove/adjust references to the passes in the docs where applicable
- Remove TTI hook associated with those passes.
- Move tests to UniformityAnalysis folder.
  - Remove RUN lines for the DA, leave only the UA ones.
- Some tests had to be adjusted/removed depending on how they used the legacy DAs.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148116

Files:
  llvm/docs/ConvergenceAndUniformity.rst
  llvm/include/llvm/ADT/GenericUniformityInfo.h
  llvm/include/llvm/Analysis/DivergenceAnalysis.h
  llvm/include/llvm/Analysis/LegacyDivergenceAnalysis.h
  llvm/include/llvm/Analysis/Passes.h
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/LinkAllPasses.h
  llvm/lib/Analysis/Analysis.cpp
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/DivergenceAnalysis.cpp
  llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp
  llvm/lib/Analysis/SyncDependenceAnalysis.cpp
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/always-uniform-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/always-uniform.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/atomics-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/atomics.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/hidden-diverge-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/hidden-diverge.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/branch-outside-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/diverged-entry-basic-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/exit-divergence-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/irreducible-1.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/irreducible/irreducible-2-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/join-loopexit-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/loads-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/never-uniform.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/temporal-diverge-gmir.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/always_uniform.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/atomics.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/b42473-r1-crash.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/control-flow-intrinsics.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/hidden_diverge.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/hidden_loopdiverge.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/inline-asm.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/interp_f16.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/intrinsics.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/branch-outside.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/diverged-entry-basic.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/diverged-entry-headers-nested.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/diverged-entry-headers.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/exit-divergence.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/irreducible-1.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/irreducible-2.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/irreducible/reducible-headers.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/join-at-loop-exit.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/join-at-loop-heart.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/kernel-args.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/lit.local.cfg
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/llvm.amdgcn.buffer.atomic.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/no-return-blocks.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/phi-undef.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/propagate-loop-live-out.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/read_register.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/temporal_diverge.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/trivial-join-at-loop-exit.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/unreachable-loop-block.ll
  llvm/test/Analysis/DivergenceAnalysis/AMDGPU/workitem-intrinsics.ll
  llvm/test/Analysis/DivergenceAnalysis/NVPTX/daorder.ll
  llvm/test/Analysis/DivergenceAnalysis/NVPTX/diverge.ll
  llvm/test/Analysis/DivergenceAnalysis/NVPTX/hidden_diverge.ll
  llvm/test/Analysis/DivergenceAnalysis/NVPTX/irreducible.ll
  llvm/test/Analysis/DivergenceAnalysis/NVPTX/lit.local.cfg
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/atomics.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/intrinsics.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/kernel-args.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/lit.local.cfg
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/llvm.amdgcn.buffer.atomic.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/loads.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/no-return-blocks.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/phi-undef.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/unreachable-loop-block.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/AMDGPU/workitem-intrinsics.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/NVPTX/diverge.ll
  llvm/test/Analysis/LegacyDivergenceAnalysis/NVPTX/lit.local.cfg
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/always-uniform-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/always-uniform.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/atomics-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/atomics.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/hidden-diverge-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/hidden-diverge.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/branch-outside-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/diverged-entry-basic-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/exit-divergence-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/irreducible-1.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/irreducible/irreducible-2-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/join-loopexit-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/loads-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/never-uniform.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/temporal-diverge-gmir.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/always_uniform.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/atomics.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/b42473-r1-crash.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/control-flow-intrinsics.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/hidden_diverge.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/hidden_loopdiverge.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/inline-asm.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/interp_f16.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/intrinsics.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/branch-outside.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/diverged-entry-basic.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/diverged-entry-headers-nested.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/diverged-entry-headers.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/exit-divergence.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/irreducible-1.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/irreducible-2.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/irreducible/reducible-headers.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/join-at-loop-exit.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/join-at-loop-heart.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/kernel-args.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/lit.local.cfg
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/llvm.amdgcn.buffer.atomic.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/no-return-blocks.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/phi-undef.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/propagate-loop-live-out.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/temporal_diverge.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/trivial-join-at-loop-exit.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/unreachable-loop-block.ll
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/workitem-intrinsics.ll
  llvm/test/Analysis/UniformityAnalysis/NVPTX/daorder.ll
  llvm/test/Analysis/UniformityAnalysis/NVPTX/diverge.ll
  llvm/test/Analysis/UniformityAnalysis/NVPTX/hidden_diverge.ll
  llvm/test/Analysis/UniformityAnalysis/NVPTX/irreducible.ll
  llvm/test/Analysis/UniformityAnalysis/NVPTX/lit.local.cfg
  llvm/test/CodeGen/AMDGPU/always-uniform.ll
  llvm/test/CodeGen/AMDGPU/smrd.ll
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/unittests/Analysis/DivergenceAnalysisTest.cpp
  llvm/utils/gn/secondary/llvm/lib/Analysis/BUILD.gn
  llvm/utils/gn/secondary/llvm/unittests/Analysis/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148116.512778.patch
Type: text/x-patch
Size: 211497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230412/b9fb6eda/attachment-0001.bin>