[PATCH] D147041: [CodeGen] Remove redundent instructions generated by combineAddrModes.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

I'm a bit confused. In the description you talk about new instructions introduced in AddressingModeCombiner::InsertPlaceholders.
The patch itself does not do anything with then. So the patch deals with the value which is used in combined addressing mode.

Another question, why did you decide to erase this instruction only one place instead of erasing it in all early bail-outs?
Don't you want to add this erasing into destructor of AddressingModeCombiner?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147041/new/

https://reviews.llvm.org/D147041