[PATCH] D147041: [CodeGen] Remove redundent instructions generated by combineAddrModes.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

In parallel, don't you want to update sinkCmpExpression to ignore dead instructions?
Additionally, In the code I see

  // If we have already inserted a cmp into this block, use it.
  CmpInst *&InsertedCmp = InsertedCmps[UserBB];

why we continue sinking icmp while we have already have on in that BB from the bug?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147041/new/

https://reviews.llvm.org/D147041