[PATCH] D146835: [RISCV] Enable usubo formation in CodeGenPrepare.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 13:37:23 PDT 2023


asb added a comment.

I start writing a comment grumbling that this adds undesirably tight coupling between with the implementation details of `TargetLowering::shouldFormOverflowOp`, but when I got to the end of it figured it wasn't that bad. If the comment had just said "Allow the transform whenever it would be allowed for UADDO" I might not have commented. LGTM. Though an assert like you suggest probably makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146835/new/

https://reviews.llvm.org/D146835



More information about the llvm-commits mailing list