[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 17:01:28 PST 2023


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:31
+;OBJ-DAG: {{([[:xdigit:]]{8})}} g .text {{([[:xdigit:]]{8})}} (idx: {{[0-9]+}}) u[RO]
+ at x = constant ptr inttoptr (i32 1 to ptr), align 4
+;CHECK:         .csect x[RO],2
----------------
This patch is not expected to change the behaviour for `x` in any way. Should the `x` case really be included? If it is, should the test for it not be for it being `RO` even with `-mno-roptr`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189



More information about the llvm-commits mailing list