[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

[Qiongsi Wu via Phabricator via llvm-commits]

qiongsiwu1 added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-roptr.ll:31
+;OBJ-DAG: {{([[:xdigit:]]{8})}} g .text {{([[:xdigit:]]{8})}} (idx: {{[0-9]+}}) u[RO]
+ at x = constant ptr inttoptr (i32 1 to ptr), align 4
+;CHECK:         .csect x[RO],2
----------------
hubert.reinterpretcast wrote:
> This patch is not expected to change the behaviour for `x` in any way. Should the `x` case really be included? If it is, should the test for it not be for it being `RO` even with `-mno-roptr`?
Thanks for the comment! This test was added because I thought we //may// expect the default behaviour of such pointers (that they are going into the RO section) to stay. If there is a change in such default behaviour, this test case can catch it. Maybe there are other tests covering this exact case but I am not sure about that. 

It sounds like that we do not need to have a test for this behaviour since it is not changed by this patch. I am removing this test. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189