[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

I think the implementation is fine, but just want to bring something else up for consideration wrt. to this option. As far as I can tell, nothing about this option is communicated in the IR. So if I split up IR generation (with `clang -emit-llvm`) and code generation (with `opt/llc`), the pointers will be placed into read-only sections only if `-mroptr` is specified to `llc`. While this isn't a common way users use the compiler, it may not be a concern. However, what are the implications of an LTO build. If we specify `-mroptr` on the compile steps but not on the link step, we won't get the behaviour. Presumably this is acceptable (i.e. the link will probably also fail if we forget to specify `-flto` on the link step) but it might be useful to document that somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189