[PATCH] D142998: [SVE][codegen] Add few more tests for MUL followed by ADD/SUB (NFC)

Mon Mar 6 04:07:53 PST 2023

sushgokh added a comment.

In D142998#4170949 <https://reviews.llvm.org/D142998#4170949>, @paulwalker-arm wrote:

> In D142998#4170452 <https://reviews.llvm.org/D142998#4170452>, @sushgokh wrote:
>
>> @paulwalker-arm Any comments/suggestions on this ?
>
> In truth I've ignored this patch whilst waiting on your other patch. My review comments on D142656 <https://reviews.llvm.org/D142656> include the test file, which I'm recommending to follow the same structure as was used for the FMAs. Those being simple tests I'm happy for them to remain included with the patch that improves the isel.  I think this patch can then be rebased on top of D142656 <https://reviews.llvm.org/D142656> to clearly show the extra cases you care about.

@paulwalker-arm As agreed in last comment for D142656 <https://reviews.llvm.org/D142656>,

1. Motive of this patch is converting to pseudo instructions.  I was assuming these are fairly simple tests with one of opernds as shuffle.  If you just expect one liners, I think tests are already present for this patch.  Agreed ?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142998/new/

https://reviews.llvm.org/D142998