[PATCH] D142998: [SVE][codegen] Add few more tests for MUL followed by ADD/SUB (NFC)

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 03:23:55 PST 2023


paulwalker-arm added a comment.

In D142998#4170452 <https://reviews.llvm.org/D142998#4170452>, @sushgokh wrote:

> @paulwalker-arm Any comments/suggestions on this ?

In truth I've ignored this patch whilst waiting on your other patch. My review comments on D142656 <https://reviews.llvm.org/D142656> include the test file, which I'm recommending to follow the same structure as was used for the FMAs. Those being simple tests I'm happy for them to remain included with the patch that improves the isel.  I think this patch can then be rebased on top of D142656 <https://reviews.llvm.org/D142656> to clearly show the extra cases you care about.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142998/new/

https://reviews.llvm.org/D142998



More information about the llvm-commits mailing list