[PATCH] D144902: [AMDGPU][AsmParser] Distinguish literal and modifier SMEM offsets.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 03:47:39 PST 2023


kosarev added a comment.

> I don't quite understand the bug here - can you explain how "s_load_dword s1, s[2:3], s0 0x1" would have been mishandled before your patch?

The `0x1` bit is currently indistinguishable from `offset:0x1` and therefore accepted as a valid operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144902/new/

https://reviews.llvm.org/D144902



More information about the llvm-commits mailing list