[PATCH] D144902: [AMDGPU][AsmParser] Distinguish literal and modifier SMEM offsets.

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

>> I don't quite understand the bug here - can you explain how "s_load_dword s1, s[2:3], s0 0x1" would have been mishandled before your patch?
>
> The `0x1` bit is currently indistinguishable from `offset:0x1` and therefore accepted as a valid operand.

Thanks, LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144902/new/

https://reviews.llvm.org/D144902