[PATCH] D144902: [AMDGPU][AsmParser] Distinguish literal and modifier SMEM offsets.

Tue Feb 28 02:17:57 PST 2023

foad added a comment.

I don't quite understand the bug here - can you explain how "s_load_dword s1, s[2:3], s0 0x1" would have been mishandled before your patch?

> I'm not sure I know where tests for things like that should go. smem-err.s should be generic enough but looks abandoned. And leaving it in gfx11_asm_err.s raises questions on how it could survive adding tests for future subtarget generations.

I think adding it to gfx11_asm_err.s is fine. If you really wanted to, you could add it to gfx*_asm_err.s for all affected architectures. Unfortunately there is a lot of duplication in the assembler tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144902/new/

https://reviews.llvm.org/D144902