[PATCH] D144807: [BOLT] Change call count output for ICF

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:1349
+
+  ParentBF.setMerged();
 }
----------------
yota9 wrote:
> Just curious may we just call ChildBF.setFolded(&ParentBF) here? AFAIU it is done only for non-relocation mode since there were no need to mark folded function in rel mode since we're just removing them from the map. If we would still mark function as folded here we may just check isFolded() state in ICF pass.
In relocation mode, ChildBF will be deleted at this point. Are you suggesting to mark ParentBF as folded?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144807/new/

https://reviews.llvm.org/D144807