[PATCH] D144807: [BOLT] Change call count output for ICF

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 06:42:28 PST 2023


yota9 added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:1349
+
+  ParentBF.setMerged();
 }
----------------
Just curious may we just call ChildBF.setFolded(&ParentBF) here? AFAIU it is done only for non-relocation mode since there were no need to mark folded function in rel mode since we're just removing them from the map. If we would still mark function as folded here we may just check isFolded() state in ICF pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144807/new/

https://reviews.llvm.org/D144807



More information about the llvm-commits mailing list