[PATCH] D144807: [BOLT] Change call count output for ICF

Mon Feb 27 11:39:31 PST 2023

yota9 added inline comments.

================
Comment at: bolt/lib/Core/BinaryContext.cpp:1349
+
+  ParentBF.setMerged();
 }
----------------
maksfb wrote:
> yota9 wrote:
> > Just curious may we just call ChildBF.setFolded(&ParentBF) here? AFAIU it is done only for non-relocation mode since there were no need to mark folded function in rel mode since we're just removing them from the map. If we would still mark function as folded here we may just check isFolded() state in ICF pass.
> In relocation mode, ChildBF will be deleted at this point. Are you suggesting to mark ParentBF as folded?
Oh you are right, for some reason I thought it is adress->pointer map.
Maybe we can use another naming then? Maybe like hasFoldedInto or isParentBF IDK. Merged sounds like the function is merged, not something into it)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144807/new/

https://reviews.llvm.org/D144807