[PATCH] D144354: [WebAssembly] Split WebAssemblyUtils to fix library layering for MC tools.

Wed Feb 22 19:23:18 PST 2023

aheejin added a comment.

Thanks! The idea makes sense to me.

================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCUtilities.cpp:21
+// Emscripten's asm.js-style exception handling
+cl::opt<bool> WebAssembly::WasmEnableEmEH(
+    "enable-emscripten-cxx-exceptions",
----------------
dschuff wrote:
> @aheejin these should maybe be on the CodeGen side rather than on the MC side, right?
Yeah, I don't think this file is very relevant to MC.

================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCUtilities.h:1
+//===-- WebAssemblyMCUtilities - WebAssembly Utility Functions -*- C++ -*-====//
+//
----------------
It looks `MCTargetDesc/WebAssemblyMCUtilities.h` and `MCTargetDesc/WebAssemblyMCUtilities.cpp` don't have any MC-related functionalities. Why do they need to be moved into `MCTargetDesc/`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144354/new/

https://reviews.llvm.org/D144354