[PATCH] D144354: [WebAssembly] Split WebAssemblyUtils to fix library layering for MC tools.

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 12:57:56 PST 2023


dschuff added a comment.

The general idea of this makes sense to me.
@pmatos and @asb have been thinking more about the type system recently, they might have an opinion.



================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCUtilities.cpp:21
+// Emscripten's asm.js-style exception handling
+cl::opt<bool> WebAssembly::WasmEnableEmEH(
+    "enable-emscripten-cxx-exceptions",
----------------
@aheejin these should maybe be on the CodeGen side rather than on the MC side, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144354/new/

https://reviews.llvm.org/D144354



More information about the llvm-commits mailing list