[PATCH] D144354: [WebAssembly] Split WebAssemblyUtils to fix library layering for MC tools.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCUtilities.h:1
+//===-- WebAssemblyMCUtilities - WebAssembly Utility Functions -*- C++ -*-====//
+//
----------------
aheejin wrote:
> It looks `MCTargetDesc/WebAssemblyMCUtilities.h` and `MCTargetDesc/WebAssemblyMCUtilities.cpp` don't have any MC-related functionalities. Why do they need to be moved into `MCTargetDesc/`?
Two of the options are used here.

```
WebAssemblyMCAsmInfo.cpp
53:  if (WebAssembly::WasmEnableEH || WebAssembly::WasmEnableSjLj)
```

I didn't look too closely to notice the other two aren't used in MC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144354/new/

https://reviews.llvm.org/D144354