[PATCH] D144519: [AMDGPU] Don't set src mods on permlane16
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 21 13:36:15 PST 2023
Joe_Nash created this revision.
Joe_Nash added reviewers: arsenm, cfang, foad.
Herald added subscribers: kosarev, StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
Joe_Nash requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.
v_permlane16_b32 and v_permlanex16_b32 should not set abs and neg src
modifiers on any input, but they can set op_sel on src0 or src1 to
represent fi or bc when desired. The ISel patterns were setting
the src_modifier bits to -1, effectively setting abs and neg as well,
whenever it was intended to set op_sel, due to an error in ISel. ISel
should now correctly only set the op_sel bits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D144519
Files:
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
llvm/lib/Target/AMDGPU/VOP3Instructions.td
llvm/test/CodeGen/AMDGPU/permlane-op-sel.ll
llvm/test/CodeGen/AMDGPU/permlane16_opsel.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144519.499282.patch
Type: text/x-patch
Size: 21207 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230221/e122cbf6/attachment.bin>
More information about the llvm-commits
mailing list