[PATCH] D144518: Preserve the address space for llvm.used and llvm.compiler.used global variables in GlobalOpt pass.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/Transforms/GlobalOpt/global-opt-addrspace.ll:8
+target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
+target triple = "spir64-unknown-unknown"
+
----------------
Don't need  triple


================
Comment at: llvm/test/Transforms/GlobalOpt/global-opt-addrspace.ll:21
+; Function Attrs: convergent mustprogress noinline norecurse optnone
+define weak_odr dso_local spir_kernel void @_ZTSZ4mainEUlvE_() #1 comdat !kernel_arg_buffer_location !5 {
+entry:
----------------
Don't need all the metadata or comdat or linkage


================
Comment at: llvm/test/Transforms/GlobalOpt/global-opt-addrspace.ll:23
+entry:
+  %0 = alloca %class.anon, align 1
+  %1 = addrspacecast ptr %0 to ptr addrspace(4)
----------------
use named values


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144518/new/

https://reviews.llvm.org/D144518