[PATCH] D144519: [AMDGPU] Don't set src mods on permlane16

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:5048
+                                                int OpIdx) const {
+  assert(OpIdx >= 0 && "expected to match an immediate operand");
+  MIB.addImm(MI.getOperand(OpIdx).getImm() ? SISrcMods::OP_SEL_0 : 0);
----------------
arsenm wrote:
> Why aren’t we using the imported pattern here?
I'm not very familiar with this part of the codebase or how GISDNodeXFormEquiv works, so I don't know what you mean.

If I delete the function renderOpSelTImm I get the error when compiling
error: no member named 'renderOpSelTImm' in 'llvm::AMDGPUInstructionSelector'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144519/new/

https://reviews.llvm.org/D144519