[PATCH] D144351: llvm-tblgen: Let each emitter self-contained

Sun Feb 19 13:27:48 PST 2023

chapuni added a reviewer: craig.topper.
chapuni added inline comments.

================
Comment at: llvm/utils/TableGen/AsmMatcherEmitter.cpp:4007

-namespace llvm {
+namespace {
+
----------------
craig.topper wrote:
> I believe LLVM coding standards say to prefer `static` over anonymous namespaces. https://llvm.org/docs/CodingStandards.html#anonymous-namespaces.  "make anonymous namespaces as small as possible, and only use them for class declarations."
I have misunderstood usage of anonymous namespace. I will rework later.

I committed also c45e90cf152decb1a3dcd208273ca025e14f1b4f as a trivial change but I have noticed I did wrong thing. I will rework as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144351/new/

https://reviews.llvm.org/D144351