[PATCH] D144351: llvm-tblgen: Let each emitter self-contained

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/AsmMatcherEmitter.cpp:4007
 
-namespace llvm {
+namespace {
+
----------------
I believe LLVM coding standards say to prefer `static` over anonymous namespaces. https://llvm.org/docs/CodingStandards.html#anonymous-namespaces.  "make anonymous namespaces as small as possible, and only use them for class declarations."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144351/new/

https://reviews.llvm.org/D144351