[PATCH] D143754: [MachineInstr] Introduce generic predicated copy opcode

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 11:18:26 PST 2023


MatzeB added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1837
+  case TargetOpcode::COPY:
+  case TargetOpcode::PRED_COPY: {
     const MachineOperand &DstOp = MI->getOperand(0);
----------------
As I still don't fully understand the point of the new opcode... I was hoping to see some extra rules and constraints here, but this feels like it allows the exact same operands and constraints as a normal COPY if there's no extra verified rules here... But then why do we need a new opcode in the first place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143754/new/

https://reviews.llvm.org/D143754



More information about the llvm-commits mailing list