[PATCH] D143229: [FunctionImporter] Add flag to disable upgrading debug info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

So your build system guarantees that all bitcode that is being consumed was generated by compilers linked against the same version of LLVM that is used in the LTO plugin and if that version were to serialize malformed metadata, you wouldn't be any worse off than a non-LTO build, which also doesn't verify between passes.

Based on that assumption, this option does make sense to me.

As others pointed out, it would be nice if the version number could be encoded in the bitcode itself, however, that doesn't fix the aforementioned trust boundary issue, so you're probably no better off than with this flag.

Considering all this, this patch gets an unenthusiastic LGTM from my side :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143229/new/

https://reviews.llvm.org/D143229