[PATCH] D144167: [UniformityAnalysis] Fix some file headers and pass names

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

Thanks for cleaning this up! It's mildly embarrassing that all this copy-pasta went through!



================
Comment at: llvm/include/llvm/Analysis/UniformityAnalysis.h:10-13
+/// \brief Convergence info and convergence-aware uniformity info for LLVM IR
 ///
 /// This differs from traditional divergence analysis by taking convergence
 /// intrinsics into account.
----------------
Actually this whole description is wrong. There are no convergene intrinsics in LLVM yet! The file description should simply say "LLVM IR instance of the generic uniformity analysis".


================
Comment at: llvm/include/llvm/CodeGen/MachineUniformityAnalysis.h:10
 /// \file
-/// \brief Uniformity info and uniformity-aware uniform info for Machine IR
+/// \brief Uniformity info for Machine IR
 //
----------------
foad wrote:
> I assume this comment was a cut-n-paste error, unless there is some very subtle distinction between "uniformity info" and "uniform info"?
I suggest "Machine IR instance of the generic uniformity analysis"


================
Comment at: llvm/lib/Analysis/UniformityAnalysis.cpp:128
 
 INITIALIZE_PASS_BEGIN(UniformityInfoWrapperPass, "uniforminfo",
+                      "Uniformity Analysis", true, true)
----------------
Perhaps this should also be "uniformity"? For example, the loop info analysis and the cycle info analysis are simply called "loops" and "cycles" respectively. This might need changes in the lit tests that invoke this analysis by name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144167/new/

https://reviews.llvm.org/D144167