[PATCH] D144167: [UniformityAnalysis] Fix some file headers and pass names

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 01:12:08 PST 2023


foad added a reviewer: sameerds.
foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineUniformityAnalysis.h:10
 /// \file
-/// \brief Uniformity info and uniformity-aware uniform info for Machine IR
 //
----------------
I assume this comment was a cut-n-paste error, unless there is some very subtle distinction between "uniformity info" and "uniform info"?


================
Comment at: llvm/lib/Analysis/UniformityAnalysis.cpp:129
 INITIALIZE_PASS_BEGIN(UniformityInfoWrapperPass, "uniforminfo",
-                      "Uniform Info Analysis", true, true)
+                      "Uniformity Analysis", true, true)
 INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
----------------
This just sounds better to me. Any objections?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144167/new/

https://reviews.llvm.org/D144167



More information about the llvm-commits mailing list